Cherry-pick #8592 to 6.x: Get cluster UUID from Info API call #8610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need @ycombinator Can also do it for you and push to your branch. |
ycombinator
force-pushed
the
backport_8592_6.x
branch
from
0699199 to
b2d6d77
Compare
|
@ruflin I double-checked that I'm running Go 1.10.3 and re-ran |
ycombinator
force-pushed
the
backport_8592_6.x
branch
from
9fa4b7d to
b2d6d77
Compare
|
Rebase didn't help. FWIW, here is another 6.x CI job that failed with the same error: https://beats-ci.elastic.co/job/elastic+beats+6.x/95/. So I think the fix, whatever it is, probably needs to happen in the 6.x branch itself? |
|
Issues here should be fixed by #8622, can you update with 6.x? |
jsoriano
approved these changes
Oct 16, 2018
Starting from 6.5.0, Elasticsearch [will return](elastic/elasticsearch#32206) the `cluster_uuid` as part of the `GET _cluster/stats` API response. However, the Elasticsearch metricbeat module has been in existence since 6.3.0 so it must fetch the cluster UUID from the `GET /` Elasticsearch API. This PR makes it so the `GET /` API is always called and the cluster UUID from it is used. This is obviously not ideal in terms of API calls, but it's the simplest fix (for now, until we can figure out a nicer way to deal with version differences). (cherry picked from commit ccfc8d7)
ycombinator
force-pushed
the
backport_8592_6.x
branch
from
b2d6d77 to
6753198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8592 to 6.x branch. Original message:
Starting from 6.5.0, Elasticsearch will return the
cluster_uuidas part of theGET _cluster/statsAPI response. However, the Elasticsearch metricbeat module has been in existence since 6.3.0 so it must fetch the cluster UUID from theGET /Elasticsearch API.This PR makes it so the
GET /API is always called and the cluster UUID from it is used. This is obviously not ideal in terms of API calls, but it's the simplest fix (for now, until we can figure out a nicer way to deal with version differences).